chore: skip jsii packaging on regular build #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsii packaging is done as part of the 'release' workflow, so don't run the packaging steps as part of the normal build.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
requested changes
Feb 20, 2025
Contributor
mrgrain
left a comment
mrgrain
left a comment
There was a problem hiding this comment.
I'm not sure about this. There is a class of errors that only occurs when you pack for jsii. Are we really okay only noticing this at release time?
Contributor
Author
|
I'm not saying it never happens, but I think I can recall this happening... oh... once ever year on some complex deep inheritance thing in the construct library? Do we want to pay the wait time for every local and PR build for those rare cases? |
mrgrain
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii packaging is done as part of the 'release' workflow, so don't run the packaging steps as part of the normal build. This saves ~17% of build time on my machine.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license